Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process tags show as span tags in Jaeger viewer with helidon-tracing-jaeger #7024

Closed
RickyFrost opened this issue Jun 19, 2023 · 0 comments · Fixed by #7027
Closed

Process tags show as span tags in Jaeger viewer with helidon-tracing-jaeger #7024

RickyFrost opened this issue Jun 19, 2023 · 0 comments · Fixed by #7027
Assignees
Labels
3.x Issues for 3.x version branch 4.x Version 4.x enhancement New feature or request

Comments

@RickyFrost
Copy link

The Jaeger viewer shows spans created with helidon-tracing-jaeger as "span tags" when they were added as tracer tags. This is a change from Helidon v2 jaeger support. Is it possible to add process tags as before? What is the way to do that?

Environment Details

  • Helidon Version: v3.2.1 SE
  • JDK version: 17.0.5
  • OS: OL7
  • Docker version (if applicable): n/a

Problem Description

When I use TracerBuilder::addTracerTag in Helidon 2 they appear as a "process" tag in the Jaeger trace viewer.
In Helidon 3 (with helidon-tracing-jaeger) they appear instead as "span" tags. I'm concerned that the change in storage class may be an issue. I'm also concerned about this visual flattening making it more difficult to view (visually parse) spans in devops triages.

The only items that show up as "process" tags are: hostname, ip, jaeger.version, and service.name.
fyi, the following tags are added to every span: otel.library.name, and otel.scope.name

Steps to reproduce

    @Test void processVsSpanTag() {
        final var tracer = io.helidon.tracing.TracerBuilder.create(Config.create().get("tracing"))
                .registerGlobal(true).enabled(true)
                .addTracerTag("tracerTag", "TracerValue") // Should appear as a "process" tag
                .build();
        final var span = tracer.spanBuilder("processVsSpanTag")
                .tag("spanTag", "SpanValue")              // Should appear as a "span" tag
                .start();
        System.out.println("Use viewer to examine processVsSpanTag in trace: "+span.context().traceId());
        span.end();
    }

As an alternative to the code approach above, I instead added them to the config as follows (same result):

tracing:
  tags:
    tracerTag: TracerValue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch 4.x Version 4.x enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants