Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: various fixes for validate workflow #5214

Merged
merged 6 commits into from
Oct 19, 2022
Merged

4.x: various fixes for validate workflow #5214

merged 6 commits into from
Oct 19, 2022

Commits on Oct 18, 2022

  1. Force upgrade of asm for maven-compiler-plugin

    @barchetta
    barchetta committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    19b28ab View commit details
    Browse the repository at this point in the history

  2. Don't alter asm version use by shade plugin

    @barchetta
    barchetta committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    53adbd4 View commit details
    Browse the repository at this point in the history

  3. Update copyright.sh

    @romain-grecourt
    romain-grecourt committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    db3d95d View commit details
    Browse the repository at this point in the history

  4. Use version 9.4 of ASM

    @barchetta
    barchetta committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    35437c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Pin workflow versions 

    Pin workflow versions:
 - runner to ubuntu-20.04 instead of unbuntu-latest
 - actions/setup-java@v3.6.0 instead of actions/setup-java@v3

Force ASM 9.4 in maven-compiler-plugin, maven-surefire-plugin, maven-javadoc-plugin

Re-use the version.lib.asm property as we need to maintain that ; hard-code the previous use of the version.lib.asm in the maven-shade-plugin
    @romain-grecourt
    romain-grecourt committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e1745b3 View commit details
    Browse the repository at this point in the history

  2. Remove toolchain profile activation 

    Remove the toolchain profile activation to normalize the environment (most developers are not using it)
    @romain-grecourt
    romain-grecourt committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    b628f2d View commit details
    Browse the repository at this point in the history