4.x: various fixes for validate workflow #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-grecourt
previously approved these changes
Oct 18, 2022
ljnelson
reviewed
Oct 18, 2022
ljnelson
previously approved these changes
Oct 18, 2022
Pin workflow versions: - runner to ubuntu-20.04 instead of unbuntu-latest - actions/setup-java@v3.6.0 instead of actions/setup-java@v3 Force ASM 9.4 in maven-compiler-plugin, maven-surefire-plugin, maven-javadoc-plugin Re-use the version.lib.asm property as we need to maintain that ; hard-code the previous use of the version.lib.asm in the maven-shade-plugin
Remove the toolchain profile activation to normalize the environment (most developers are not using it)
barchetta
changed the title
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GitHub released https://github.com/actions/setup-java/releases/tag/v3.6.0 our build broke in the PR validator workflow. Why? Because that release added support for toolchains, and our toolchain profile autoactivated which triggered an obscure issue with Java 19 generate module files because of on old version of ASM.
This PR addresses the asm issue and makes a few changes so that our validation builds are reproducible. Specifically:
setup-javaaction to 3.6.0 instead of latest v3toolchainprofile on existence of${user.home}/.m2/toolchains.xmlThanks to @romain-grecourt for these changes.