Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few problems with Fallback and Multi's in SE #4157

Merged
merged 1 commit into from
May 4, 2022

Conversation

spericas
Copy link
Member

@spericas spericas commented Apr 26, 2022

Fixed a few problems with Fallback and Multi's in SE. Updated Fallback implementation to mimic exception nesting/structure of Single for Multi. Issue #4155.

Note that the signature of the createMulti method has changed, but seemed incorrect before.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

… Multi's using Fallback. Updated Fallback implementation to mimic exception nesting/structure of Single for Multi.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Indeed the signatures seems wrong, and a test was missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants