Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback.createMulti does not call correct method in builder #4155

Closed
spericas opened this issue Apr 25, 2022 · 1 comment
Closed

Fallback.createMulti does not call correct method in builder #4155

spericas opened this issue Apr 25, 2022 · 1 comment
Assignees
@spericas
Labels
fault-tolerance

Comments

@spericas
Copy link
Member

spericas commented Apr 25, 2022 •
edited
Loading

There's a copy/paste error in Fallback<T> createMulti(Function<Throwable, ? extends CompletionStage<T>> fallback). We also seem to lack proper testing for this method.
@spericas spericas self-assigned this Apr 25, 2022
@spericas spericas mentioned this issue Apr 26, 2022
Merged
@spericas spericas mentioned this issue May 4, 2022
Merged
@spericas
Copy link
Member Author

spericas commented May 4, 2022

PR #4157
PR #4176

@spericas spericas closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spericas spericas

Labels
fault-tolerance
Projects
Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spericas