Issue 3926 - Hocon #includes not handled properly #3960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) HOCON's #include is enabled OOTB by default; if we need to disable it we will need to take measures to disable it (not included in this change). @laird: note that the default options are initialized with null for includer, but then it patches it in later. 2) The bug appears to be located in BuilderImpl in that it doesn't properly reflect the config file path into HOCON for nested directories. If this is a feature of Helidon, there is an element of surprise with that choice, since most users would expect an include to resolve to the CWD, and not the base directory. Will wait for guidance on how to proceed..
1) HOCON's #include is enabled OOTB by default; if we need to disable it we will need to take measures to disable it (not included in this change). @laird: note that the default options are initialized with null for includer, but then it patches it in later. 2) The bug appears to be located in BuilderImpl in that it doesn't properly reflect the config file path into HOCON for nested directories. If this is a feature of Helidon, there is an element of surprise with that choice, since most users would expect an include to resolve to the CWD, and not the base directory. Will wait for guidance on how to proceed..
1) HOCON's #include is enabled OOTB by default; if we need to disable it we will need to take measures to disable it (not included in this change). @laird: note that the default options are initialized with null for includer, but then it patches it in later. 2) The bug appears to be located in BuilderImpl in that it doesn't properly reflect the config file path into HOCON for nested directories. If this is a feature of Helidon, there is an element of surprise with that choice, since most users would expect an include to resolve to the CWD, and not the base directory. Will wait for guidance on how to proceed..
trentjeff
changed the title
|
replaced with a newer PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discoveries:
This PR Fixes #3926 for discoveries above.
@tomas-langer will need to discuss this with you since I went much deeper than I was hoping to go. I've made notes in the code for specific things you should pay particular attention to. I'm guessing there are more appropriate ways to handle, but was not sure where to look. See slack thread for more background.