Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hocon configs does not support include #3926

Closed
aljawado700 opened this issue Mar 1, 2022 · 5 comments
Closed

Hocon configs does not support include #3926

aljawado700 opened this issue Mar 1, 2022 · 5 comments
Assignees
Labels
config enhancement New feature or request OCI P2
Milestone

Comments

@aljawado700
Copy link

Environment Details

  • Helidon Version: 2.4.1
  • Helidon SE or Helidon MP: SE
  • JDK version: 17
  • OS: mac os Montery
  • Docker version (if applicable): N/A

Problem Description

hocon cofigs directive "include" does not work.

repro: create two config files 1.conf and 2.conf. Add include 1 in 2.

@trentjeff
Copy link
Member

@ljnelson
Copy link
Member

ljnelson commented Mar 1, 2022

@tomas-langer looks to me (I don't know this area at all) like Helidon's HOCON support is not allowing customization of the ConfigFactory options that would permit this use case:

https://github.com/oracle/helidon/blob/b3fd9c0d19b1d8a2fc090a8c212cb7b2179d1407/config/hocon/src/main/java/io/helidon/config/hocon/HoconConfigParser.java#L129

We're using this:

https://github.com/lightbend/config/blob/v1.4.1/config/src/main/java/com/typesafe/config/ConfigFactory.java#L739-L741

…and the default options do not include a ConfigIncluder:

https://github.com/lightbend/config/blob/v1.4.1/config/src/main/java/com/typesafe/config/ConfigParseOptions.java#L47-L49

Do you concur?

@m0mus m0mus added enhancement New feature or request config P3 P2 and removed P3 labels Mar 3, 2022
@m0mus m0mus added this to the 2.4.3 milestone Mar 3, 2022
@trentjeff
Copy link
Member

@ljnelson , place take a look at what i have put together so far here - https://github.com/oracle/helidon/compare/master...trentjeff:issue-3926?expand=1

@trentjeff
Copy link
Member

@barchetta fyi

@trentjeff
Copy link
Member

fixed and merged in 2.x and master - #3998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config enhancement New feature or request OCI P2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants