Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nima: WebClient Proxy Support #6006

Closed
Tracked by #6741
, #7094
...
klustria opened this issue Jan 30, 2023 · 1 comment
Closed
Tracked by #6741
, #7094
...

Nima: WebClient Proxy Support #6006

klustria opened this issue Jan 30, 2023 · 1 comment
Assignees
@jbescos @tomas-langer
Labels
4.x Version 4.x Níma Helidon Níma task To do webclient
Milestone
4.0.0-M1

Comments

@klustria
Copy link
Member

klustria commented Jan 30, 2023 •
edited
Loading

Environment Details

  • Helidon Version: 4
  • Helidon Nima

Problem Description

Nima WebClient does not have Proxy support. This issue is spawned off from #5386 to cover the proxy support implementation on Nima client.
@klustria klustria added task To do 4.x Version 4.x Níma Helidon Níma labels Jan 30, 2023
This was referenced Jan 30, 2023
Closed
Closed
@klustria klustria self-assigned this Jan 31, 2023
@tomas-langer tomas-langer changed the title Nima: ClientRequestImpl Proxy Support Nima: WebClient Proxy Support Feb 2, 2023
@m0mus m0mus added this to the 4.0.0 milestone Feb 2, 2023
@jbescos jbescos self-assigned this Feb 10, 2023
@tomas-langer tomas-langer mentioned this issue Feb 12, 2023
Closed
@klustria
Copy link
Member Author

Once this is implemented, please make sure that Proxy is added as part of the key (KeepAliveKey) in https://github.com/helidon-io/helidon/blob/main/nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/ClientRequestImpl.java#L330-L331

jbescos added a commit to jbescos/helidon that referenced this issue Feb 23, 2023
@jbescos
Nima: WebClient Proxy Support helidon-io#6006
9f96e23 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos jbescos mentioned this issue Mar 21, 2023
Merged
@barchetta barchetta modified the milestones: 4.0.0, 4.0.0-M2 Apr 17, 2023
This was referenced May 2, 2023
Closed
Closed
@tomas-langer tomas-langer self-assigned this May 12, 2023
@klustria klustria mentioned this issue Jun 7, 2023
Closed
@Verdent Verdent mentioned this issue Jun 8, 2023
Closed
@m0mus m0mus modified the milestones: 4.0.0-M2, 4.0.0-M1 Jun 22, 2023
@m0mus m0mus assigned Verdent and unassigned Verdent Jun 26, 2023
@romain-grecourt romain-grecourt mentioned this issue Jun 26, 2023
Closed
10 tasks
jbescos added a commit that referenced this issue Jul 3, 2023
@jbescos
Nima: WebClient Proxy Support (#6441)
47e23a3 
Nima: WebClient Proxy Support #6006

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbescos jbescos

@tomas-langer tomas-langer

Labels
4.x Version 4.x Níma Helidon Níma task To do webclient
Projects
Backlog
Archived in project
Milestone
4.0.0-M1
Development

No branches or pull requests
7 participants
@romain-grecourt @Verdent @jbescos @barchetta @m0mus @tomas-langer @klustria