Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Proxy setting as part of deciding relativeURIs logic #6962

Closed
klustria opened this issue Jun 7, 2023 · 3 comments
Closed

Include Proxy setting as part of deciding relativeURIs logic #6962

klustria opened this issue Jun 7, 2023 · 3 comments
Assignees
Labels
4.x Version 4.x Níma Helidon Níma webclient
Milestone

Comments

@klustria
Copy link
Member

klustria commented Jun 7, 2023

Environment Details

  • Helidon Version: Main
  • Helidon NIMA

Problem Description

#6803 added relativeURIs config to determine if relative or absolute URI will be used in the request as a feature parity with Helidon SE. However, proxy configuration also needs to be a factor in deciding on the form of URI to send. Particularly, when you use proxy, Helidon SE WebClient will use absolute URI in the request because of changes made in #2302 and #3438. The use of absolute URI was implemented because of section 5.1.2 Request-URI in https://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html which states:

The absoluteURI form is REQUIRED when the request is being made to a proxy.

Because of this, we need to replicate this behavior in Helidon NIMA. However, NIMA proxy implementation is still in the works in #6006, so this change will have to wait.

@klustria klustria self-assigned this Jun 7, 2023
@klustria klustria added 4.x Version 4.x webclient Níma Helidon Níma labels Jun 7, 2023
@klustria klustria added this to the 4.0.0-M2 milestone Jun 7, 2023
@klustria
Copy link
Member Author

klustria commented Jun 7, 2023

Since #6006 Nima: WebClient Proxy Support is a prerequisite of this change and that issue is slated for 4.0.0-M2, then I'm setting this to that milestone as well.

@klustria klustria changed the title Include Proxy setting when deciding relativeURIs logic Include Proxy setting as part of deciding relativeURIs logic Jun 8, 2023
@klustria
Copy link
Member Author

This will dealt with in PR #7425

@klustria
Copy link
Member Author

PR #7425 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x Níma Helidon Níma webclient
Projects
Archived in project
Development

No branches or pull requests

1 participant