Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce update when contact method already exists in configuration #102

Merged

Conversation

imjaroiswebdev
Copy link
Collaborator

This update addresses the case when a contact method is try to be updated with a value that already exists in the configuration, which previous this change it only was returning the data of the existent contact, but didn't execute the update, from this update on the contact method will be replaced (updated) as expected.

This update introduces TestUsersUpdateExistentContactMethod as test case to validate the expected result in this case.

Screenshot 2022-12-05 at 10 47 26

Copy link
Collaborator

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🌮 🎉

@imjaroiswebdev imjaroiswebdev merged commit 2a3d8ee into heimweh:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants