Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address: Unique contact method error not being captured #586

Conversation

imjaroiswebdev
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev commented Nov 4, 2022

Address: #583

Additionally an update to the documentation of the pagerduty_user_contact_method resource has been introduced to clarify the particular way in which this resource behaves...
Screenshot 2022-12-05 at 10 59 03

Test results...

Screenshot 2022-12-01 at 00 14 11

@imjaroiswebdev imjaroiswebdev marked this pull request as draft November 4, 2022 16:24
@imjaroiswebdev imjaroiswebdev force-pushed the issue-583-contact-meth-change-no-reflected branch from 7615192 to 1318662 Compare December 5, 2022 13:30
`go mod edit -replace github.com/heimweh/go-pagerduty=github.com/imjaroiswebdev/go-pagerduty@enforce-existent-contact && go mod tidy && go mod vendor`
@imjaroiswebdev
Copy link
Contributor Author

Depends on heimweh/go-pagerduty#102

`go mod edit -dropreplace github.com/heimweh/go-pagerduty && go get github.com/heimweh/go-pagerduty/pagerduty && go mod tidy && go mod vendor`
@imjaroiswebdev imjaroiswebdev force-pushed the issue-583-contact-meth-change-no-reflected branch from 1318662 to 19d77e8 Compare December 6, 2022 20:53
@imjaroiswebdev imjaroiswebdev marked this pull request as ready for review December 6, 2022 20:56
Scott McAllister added 2 commits December 7, 2022 17:31
Helped to clarify the wording a bit in the Note added to the User Contact Method docs.
sorry. this formatting looks like it should work better.
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just made a few changes to the wording in the docs.

My bad. I removed the desired formatting. This commit puts it back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants