cmake, lint: Adjust lint_includes_build_config
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping @maflcko :) |
hebasto
force-pushed
the
240428-cmake-EK
branch
from
c664442 to
bb43c66
Compare
|
Rebased. |
hebasto
force-pushed
the
240428-cmake-EK
branch
from
bb43c66 to
459f016
Compare
|
Rebased. |
hebasto
added a commit
that referenced
this pull request
May 7, 2024
448132a fixup! cmake, doc: Update `build-freebsd.md` (Hennadii Stepanov) 9bafc55 fixup! cmake, doc: Update `build-osx.md` (Hennadii Stepanov) a0a98ff fixup! cmake, docs: Update MSVC build docs (Hennadii Stepanov) Pull request description: This PR amends build docs according the discussion in #167 where there were agreed to use modern cmake invocations. Simplifies #173 and #177. ACKs for top commit: vasild: ACK 448132a Tree-SHA512: cf49f258b6f65098603a0e33ec2a3f11665d83ee87efe3fc11ff59a2a92ba798c4e127896052cf934b0fcabbbfa6a87c880341458b0c12cfbc7b7a4465f9c413
Adjust copyright header.
CMake allows to incorporate compile defines into a target as its property with applying automatically where required.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter has been adjusted to consider CMake-specific
bitcoin-config.h.infile.Linter warnings have been fixed.
Can be tested by running linters locally.