-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Add WITH_DBUS
configuration option
#176
Conversation
Is this actually something we need (to port) an option for. |
cc @laanwj |
i think so. Not all UNIX platforms use DBUS. On Linux it's safe to assume it's there. On MacOS and Windows it's not a thing. FWIW i tried to get rid of the custom notification stuff a while ago, but Qt's notificator still falls back to ancient X11 notifications which are ignored (or look very shitty) on modern Linux. Maybe qt6 changes this? i dunno. But for now t's really necessary. |
Should probably get rid of the |
Sure. Removed. |
Rebased. |
Rebased on top of the merged #173. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR adds a new
WITH_DBUS
configuration option, which is an analogue of Autotools'--with-qtdbus
.