Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#502): extend CSP to work with monaco-editor #552

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

mmelko
Copy link
Contributor

@mmelko mmelko commented Oct 17, 2024

closes #502

@phantomjinx
Copy link
Member

@mmelko if you rebase this then the tests should now pass.

@grgrzybek
Copy link

Hmm - does this mean it'll work when monaco will be loaded from CDN?
What about offline/dmz environments with limited access to Internet?
Won't it work when loading from Hawtio origin?

@mmelko
Copy link
Contributor Author

mmelko commented Oct 18, 2024

@grgrzybek hmm valid point. This change comes from PF5 upgrade and it should replace webpack requirements afaik

@phantomjinx phantomjinx merged commit 5653903 into hawtio:main Oct 24, 2024
2 checks passed
@grgrzybek
Copy link

grgrzybek commented Oct 24, 2024

We need to apply these instructions.

@grgrzybek
Copy link

grgrzybek commented Oct 24, 2024

I'm working on a fix to NOT have https://cdn.jsdelivr.net/npm/monaco-editor specified explicitly in CSP headers...

@grgrzybek
Copy link

Currently, when viewing Camel source code (which contains <CodeEditor> Patternfly component, we see this:
image

@grgrzybek
Copy link

Looks like it worked with these instructions:
image

@grgrzybek
Copy link

See hawtio/hawtio-next#1186

@grgrzybek
Copy link

grgrzybek commented Oct 24, 2024

After hawtio/hawtio-next#1187 is merged and new @hawtio/react version is used in Hawtio online, please remove CDN host from CSP header. I'll do the same for hawtio/hawtio's ContentSecurityPolicyFilter.

cc: @phantomjinx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monaco fails loading on Hawtio Online
4 participants