Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(monaco): Do not use CDN version of monaco-editor (fixes #1186) #1187

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(monaco): Do not use CDN version of monaco-editor (fixes #1186) #1187

merged 1 commit into from
Oct 24, 2024
+22 −0

Conversation

grgrzybek
Copy link
Contributor

No description provided.

phantomjinx
phantomjinx approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgrzybek grgrzybek mentioned this pull request Oct 24, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Test Results

  8 files  ±0    8 suites  ±0   57m 40s ⏱️ + 10m 46s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit d744ab3. ± Comparison against base commit 64e7103.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Oct 24, 2024 •
edited
Loading

Test results

Run attempt: 2597
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 425.894
test-results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 429.243
test-results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 443.057
test-results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 426.5
test-results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 437.992
test-results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 431.182
test-results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 435.436
test-results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 431.108

@grgrzybek grgrzybek merged commit f0805fa into main Oct 24, 2024
13 checks passed
@grgrzybek grgrzybek deleted the monaco-cdn-issue branch October 24, 2024 15:26
@mmelko
Copy link
Collaborator

mmelko commented Oct 24, 2024

excelent!

grgrzybek added a commit that referenced this pull request Oct 25, 2024
@grgrzybek
fix(monaco): Do not use CDN version of monaco-editor (fixes #1186) (#…
8022fdf 
…1187)

(cherry picked from commit f0805fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phantomjinx phantomjinx phantomjinx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grgrzybek @mmelko @phantomjinx