Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AboutModal): Add backgroung image to aboutModal #1188

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented Oct 24, 2024

This PR also adds possibility to set about background in the hawtconfig.json and adds RH backround that can be used in the the product.
closes #1031

Current about when running yarn start:
Screenshot 2024-10-24 at 18 29 33

with the RH background-inverted:
Screenshot 2024-10-24 at 22 39 49

Copy link

Test Results

  8 files  ±0    8 suites  ±0   57m 48s ⏱️ +22s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit 235b077. ± Comparison against base commit f0805fa.

@hawtio-ci
Copy link

hawtio-ci bot commented Oct 24, 2024

Test results

Run attempt: 2599
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 439.724
test-results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 428.853
test-results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 424.302
test-results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 437.632
test-results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 427.057
test-results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 445.997
test-results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 425.909
test-results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 439.174

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update hawtio-website once it's merged

https://hawt.io/docs/configuration.html#_hawtconfig_json

@mmelko mmelko merged commit af8ac3c into hawtio:main Oct 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About - Background image isn't displayed
2 participants