Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About - Background image isn't displayed #1031

Closed
tadayosi opened this issue Jul 17, 2024 · 2 comments · Fixed by #1188
Closed

About - Background image isn't displayed #1031

tadayosi opened this issue Jul 17, 2024 · 2 comments · Fixed by #1188
Assignees
@mmelko
Labels
area/ui kind/bug Something isn't working
Milestone
2024Q4

Comments

@tadayosi
Copy link
Member

Running yarn start and open the about modal:

image

while the PF 5 demo looks like:

https://www.patternfly.org/components/about-modal/

image
@tadayosi tadayosi added kind/bug Something isn't working area/ui labels Jul 17, 2024
@tadayosi tadayosi added this to the 2024Q3 milestone Jul 17, 2024
@tadayosi
Copy link
Member Author

@mmelko Can you have a look?

@mmelko
Copy link
Collaborator

mmelko commented Aug 6, 2024

yeah I will look at this. IIRC it's not actual background but rather svg icon scaled big.

@tadayosi tadayosi modified the milestones: 2024Q3, 2024Q4 Oct 8, 2024
mmelko added a commit to mmelko/hawtio-next that referenced this issue Oct 24, 2024
@mmelko
fix(AboutModal): Add backgroung image to aboutModal
6d3bb7e 
closes hawtio#1031
mmelko added a commit to mmelko/hawtio-next that referenced this issue Oct 24, 2024
@mmelko
fix(AboutModal): Add backgroung image to aboutModal
1abb85d 
closes hawtio#1031
mmelko added a commit to mmelko/hawtio-next that referenced this issue Oct 24, 2024
@mmelko
fix(AboutModal): Add backgroung image to aboutModal
235b077 
closes hawtio#1031
@mmelko mmelko mentioned this issue Oct 24, 2024
Merged
@mmelko mmelko closed this as completed in af8ac3c Oct 25, 2024
mmelko added a commit to mmelko/hawtio-next that referenced this issue Oct 25, 2024
@mmelko
fix(AboutModal): Add backgroung image to aboutModal
2de27d3 
closes hawtio#1031

(cherry picked from commit af8ac3c)
tadayosi pushed a commit that referenced this issue Oct 25, 2024
@mmelko @tadayosi
fix(AboutModal): Add backgroung image to aboutModal
f9014e8 
closes #1031

(cherry picked from commit af8ac3c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmelko mmelko

Labels
area/ui kind/bug Something isn't working
Projects
Kanban Board
Status: Done
Milestone
2024Q4
Development

Successfully merging a pull request may close this issue.

fix(AboutModal): Add backgroung image to aboutModal mmelko/hawtio-next
2 participants
@tadayosi @mmelko