Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on Deflate64 compressed files #10

Closed
wants to merge 1 commit into from

Conversation

idiom
Copy link

@idiom idiom commented Feb 17, 2017

Return mode=failed with Deflate64 compressed files. These fail with the unzip package and causes a runtime exception to be thrown and processing to stop when running through a directory of files.

A future enhancement could be to detect these types of compressed zip files and use the 7z unpacker instead.

Return mode=failed with Deflate64 compressed files.
@jbremer
Copy link
Member

jbremer commented Feb 17, 2017

You make a good point. In fact, perhaps it would be a good step forward to have .7z take precedence over .zip unpacking, so that any .zip file is unpacked with .7z, if available. This would also make sense performance-wise etc.

@coveralls
Copy link

coveralls commented Feb 17, 2017

Coverage Status

Coverage increased (+0.03%) to 92.837% when pulling a3b950d on idiom:pull_requests into 31c28ab on jbremer:master.

@codecov-io
Copy link

Codecov Report

Merging #10 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   93.51%   93.53%   +0.02%     
==========================================
  Files          18       18              
  Lines         709      712       +3     
==========================================
+ Hits          663      666       +3     
  Misses         46       46
Impacted Files Coverage Δ
sflock/unpack/zip.py 95.74% <100%> (+0.29%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c28ab...a3b950d. Read the comment docs.

@idiom
Copy link
Author

idiom commented Oct 17, 2017

Hmm this fell off my radar =\ I'll close this pull request and take a look at the associated issue.

@idiom idiom closed this Oct 17, 2017
@idiom idiom deleted the pull_requests branch October 17, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants