Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give 7z precedence over zipfile #25

Open
jbremer opened this issue Aug 17, 2017 · 1 comment
Open

give 7z precedence over zipfile #25

jbremer opened this issue Aug 17, 2017 · 1 comment

Comments

@jbremer
Copy link
Member

jbremer commented Aug 17, 2017

By doing so we get the extra benefits that may be found in 7z as compared to zipfile (e.g., performance) while also adding deflate64 support (see also #10).

@idiom
Copy link

idiom commented Oct 17, 2017

Yeah, I like this approach since instead of failing, it will produce a usable (extracted) file in the case of #10 . Doing some quick tests guess() looks to select 7zip if the supported extensions are updated, but I'm not sure this can be relied on. We could add some logic that sets 7zip as the unpacker where it is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants