Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.{guess,sub} files. #510

Closed
wants to merge 1 commit into from
Closed

Update config.{guess,sub} files. #510

wants to merge 1 commit into from

Conversation

villesokk
Copy link
Contributor

Currently when building network on an M1 Mac I get the following error:

checking build system type... Invalid configuration `arm64-apple-darwin20.6.0': machine `arm64-apple' not recognized

The current versions of config.{sub,guess} don't recognise arm64-apple. This PR updates these files with versions from GNU Savannah's config.git repository.

@kazu-yamamoto kazu-yamamoto self-requested a review October 5, 2021 11:13
kazu-yamamoto
kazu-yamamoto approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have M1 Mac yet. But this looks excellent!

kazu-yamamoto added a commit to kazu-yamamoto/network that referenced this pull request Oct 5, 2021
@kazu-yamamoto
Merge PR haskell#510
cb73cea
@kazu-yamamoto
Copy link
Collaborator

Merged. Thank you for your contribution!
I should release a new version.

@Mikolaj Mikolaj mentioned this pull request Oct 7, 2021
Closed
@hasufell
Copy link
Member

hasufell commented Oct 7, 2021 •
edited
Loading

@villesokk can you test https://downloads.haskell.org/~ghcup/tmp/network-3.1.2.3.tar.gz please? It contains the new files, but configure was generated with autoconf 2.69.

I've been trying to test this on GHCs CI, but due go nix cache shenanigans, it might take forever.

@hasufell hasufell mentioned this pull request Oct 7, 2021
Closed
@villesokk
Copy link
Contributor Author

villesokk commented Oct 7, 2021 •
edited
Loading

@villesokk can you test https://downloads.haskell.org/~ghcup/tmp/network-3.1.2.3.tar.gz please? It contains the new files, but configure was generated with autoconf 2.69.

I've been trying to test this on GHCs CI, but due go nix cache shenanigans, it might take forever.

Just to be sure: you would like me to test it on an M1 Mac?

@hasufell
Copy link
Member

hasufell commented Oct 7, 2021

Just to be sure: you would like me to test it on an M1 Mac?

yes

@villesokk
Copy link
Contributor Author

With GHC 8.10.7, cabal 3.6.0.0 (both installed from brew) and Apple clang 12.0.5 it built successfully.

@hasufell
Copy link
Member

hasufell commented Oct 7, 2021

Could you also test with 3.4.0.0? (if it's not in brew, it's in ghcup)

@villesokk
Copy link
Contributor Author

villesokk commented Oct 7, 2021 •
edited
Loading

I compiled cabal-install 3.4.0.0 from Hackage, tried a clean build of network 3.1.2.3 with it and it succeeded. Can I help in some other way (I don't know anything about developing on Windows unfortunately)?

@hasufell
Copy link
Member

hasufell commented Oct 7, 2021

tried a clean build of network 3.1.2.3

Just to confirm... you used the network tarball I linked, right?

@villesokk
Copy link
Contributor Author

Yes, I used your .tar.gz on both attempts.

@stackptr stackptr mentioned this pull request Nov 2, 2021
Merged
ceedubs added a commit to ceedubs/unison that referenced this pull request Oct 5, 2022
@ceedubs
network: 3.1.1.1 -> 3.1.2.7
0292ca2 
I finally got around to trying to build Unison on my M1 Mac with an ARM
version of Stack instead of through x86 emulation, and I ran into [this
issue](haskell/network#510). Bumping the
`network` dependency a bit seems to resolve the issue.

Stack made a bunch of unrelated changes to the lock file, mostly just
moving fields around but in some cases updating their values. I don't
know why it moved stuff around, and I can't find any information about
how to make it only update a single package. Is this just a thing that
Stack does?

All of the tests and transcripts run fine with this change, and after
kicking the tires a bit I didn't see any issues.
@ceedubs ceedubs mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@villesokk @kazu-yamamoto @hasufell