Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Add network-3.1.2.5 to 18.13 snapshot #15

Merged
merged 6 commits into from
Nov 2, 2021
Merged

Add network-3.1.2.5 to 18.13 snapshot #15

merged 6 commits into from
Nov 2, 2021

Conversation

stackptr
Copy link
Member

@stackptr stackptr commented Nov 2, 2021

This pulls in a fix for the package configuration files to recognize arm64-apple systems, see: haskell/network#510

@stackptr stackptr self-assigned this Nov 2, 2021
@stackptr stackptr marked this pull request as ready for review November 2, 2021 17:07
Copy link
Contributor

@eborden eborden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These snapshots are immutable and cannot be changed once they are deployed. You'll need to introduce a new snapshot for this lts/18/13/FR1.yaml.

@stackptr
Copy link
Member Author

stackptr commented Nov 2, 2021

Ah, I saw #14 but now see that that was special because the snapshot was utilized.

Copy link
Contributor

@eborden eborden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be lts/18/13/FR1.yaml

see: https://github.com/freckle/stackage-snapshots#snapshots

@stackptr stackptr requested a review from eborden November 2, 2021 18:06
Copy link
Contributor

@eborden eborden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope

@stackptr
Copy link
Member Author

stackptr commented Nov 2, 2021

Sorry for the noise, I had thought this exception when updating the resolver to use this branch was related to the resolver field in the YAML and not the path itself:

Exception while reading snapshot from https://raw.githubusercontent.com/freckle/stackage-snapshots/corey/13-FR1/lts/18/13-FR1.yaml:
Specified snapshot as file path with "lts-18.13-FR1", but not reading from a local file
Type help for available commands. Press enter to force a rebuild.

Copy link
Contributor

@eborden eborden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stackptr
Copy link
Member Author

stackptr commented Nov 2, 2021

Sure!

@stackptr stackptr requested a review from eborden November 2, 2021 19:35
@stackptr stackptr merged commit d4cd57b into main Nov 2, 2021
@stackptr stackptr deleted the corey/13-FR1 branch November 2, 2021 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants