Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hidden Args. #5111

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Fix Hidden Args. #5111

merged 2 commits into from
Feb 6, 2018

Conversation

angerman
Copy link
Collaborator

@angerman angerman commented Feb 5, 2018

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

When trying to make the "target-package-db" flag hidden in #4892, I unintentionally also
made it unrecognized. This should rectify that and also make the code more readable.

@angerman angerman requested a review from 23Skidoo February 5, 2018 06:22
@angerman
Copy link
Collaborator Author

angerman commented Feb 5, 2018

Alright, LambdaCase not available in 7.4

@angerman angerman self-assigned this Feb 5, 2018
@23Skidoo 23Skidoo added this to the 2.2 milestone Feb 5, 2018
@angerman
Copy link
Collaborator Author

angerman commented Feb 6, 2018

And it's green... after massaging Travis :(

Copy link
Member

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@23Skidoo 23Skidoo merged commit b995380 into haskell:master Feb 6, 2018
@23Skidoo
Copy link
Member

23Skidoo commented Feb 6, 2018

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants