Allow ${pkgroot} prefix. #4892

angerman · 2017-11-15T06:00:41Z

This change adds the ability to pass --prefix=\${pkgroot}. It is on purpose undocumented, as it should be only used with absolute care.

Please include the following checklist in your PR:

Patches conform to the coding conventions.
Any changes that could be relevant to users have been recorded in the changelog.
The documentation has been updated, if necessary.
If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

Fixes #4872

angerman · 2017-11-15T06:11:04Z

@23Skidoo, @hvr this is not good, AppVeyor seems dead:

Build started
git clone -q https://github.com/haskell/cabal.git C:\projects\cabal
git fetch -q origin +refs/pull/4892/merge:
git checkout -qf FETCH_HEAD
Running Install scripts
choco install -y ghc --version 8.0.2
Chocolatey v0.10.7
Installing the following packages:
ghc
By installing you accept licenses for the packages.
Progress: Downloading cabal 2.0.0.0... 100%
Progress: Downloading ghc 8.0.2... 100%
cabal v2.0.0.0 [Approved]
cabal package files install completed. Performing other installation steps.
 ShimGen has successfully created a shim for cabal.exe
 The install of cabal was successful.
  Software install location not explicitly set, could be in package or 
  default install location if installer.
ghc v8.0.2 [Approved]
ghc package files install completed. Performing other installation steps.
Attempt to get headers for https://downloads.haskell.org/~ghc/8.0.2/ghc-8.0.2-x86_64-unknown-mingw32.tar.xz failed.
  The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://downloads.haskell.org/~ghc/8.0.2/ghc-8.0.2-x86_64-unknown-mingw32.tar.xz'. Exception calling "GetResponse" with "0" argument(s): "The operation has timed out"
Downloading ghc 64 bit
  from 'https://downloads.haskell.org/~ghc/8.0.2/ghc-8.0.2-x86_64-unknown-mingw32.tar.xz'
ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://downloads.haskell.org/~ghc/8.0.2/ghc-8.0.2-x86_64-unknown-mingw32.tar.xz'. Exception calling "GetResponse" with "0" argument(s): "The operation has timed out" 
This package is likely not broken for licensed users - see https://chocolatey.org/docs/features-private-cdn.
The install of ghc was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\ghc\tools\chocolateyInstall.ps1'.
 See log for details.
Chocolatey installed 1/2 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Failures
 - ghc (exited 404) - Error while running 'C:\ProgramData\chocolatey\lib\ghc\tools\chocolateyInstall.ps1'.
 See log for details.
Command exited with code 404

23Skidoo · 2017-11-15T10:45:10Z

I'm OK with adding an undocumented dangerous feature, but it'd be nice if @dcoutts could take a look.

angerman · 2017-11-15T12:21:17Z

I think I'll go and add --target-package-db flags to install and copy. That should give that prefix meaning. Just to be clear, I'll try to see how much relocatable issues I will be able to lift. But I'd rather try this piecemeal.

angerman · 2017-11-20T12:44:00Z

@23Skidoo how does this look now?

angerman · 2017-11-23T11:47:53Z

@23Skidoo, @hvr any chance I can get a review of this an a prelimiary one of #4874? As the general plan (as I understood @bgamari) now is to try to go ahead with snowleopard/hadrian#445 for 8.4, both are pre-requisits. And I'd like to get them finished in Cabal as soon as I can. As such any critique or "please do this and that" would be much appreciated!

Sorry to bother :(

23Skidoo · 2017-11-24T16:09:36Z

cabal-install/Distribution/Client/Setup.hs

@@ -1663,6 +1665,12 @@ installOptions showOrParseArgs =
          "Do not install anything, only print what would be installed."
          installDryRun (\v flags -> flags { installDryRun = v })
          trueArg
+
+      , option "" ["target-package-db"]


Can we make this a hidden option?

Can you give me a pointer where I can find a hidden option? I've tried looking for hiddenOption, and anything with hidden and option, but didn't turn anything up.

@23Skidoo so I fail to figure out how to make this a hidden option. I also tried to set the help-text to "" as per suggestion by @hvr, but that didn't drop it from being displayed either.

23Skidoo · 2017-11-24T16:14:43Z

Cabal/Distribution/Simple/InstallDirs.hs



 -- |The location prefix for the /copy/ command.
 data CopyDest
  = NoCopyDest
  | CopyTo FilePath
-  deriving (Eq, Show)
+  | CopyToDb FilePath


Needs a Haddock comment.

23Skidoo · 2017-11-24T16:15:01Z

Cabal/Distribution/Simple/Setup.hs

+         copyDest (\v flags -> case copyDest flags of
+                      NoFlag -> flags { copyDest = v }
+                      Flag NoCopyDest -> flags { copyDest = v }
+                      _ -> error "Use either 'destdir' or 'target-package-db'.")


Use either 'destdir' or 'target-package-db'

, but not both? I think that this breaks --destdir=foo --destdir=bar, which used to work.

Well, if --target-package-db is given, --destdir makes no sense. But allowing to specify --destdir twice (that would just take the latter one, I believe), if that used to be the behaviour should definitely stay that way.

23Skidoo · 2017-11-27T01:43:40Z

@angerman Hidden flags are currently implemented in a somewhat ad hoc way, see https://github.com/haskell/cabal/blob/master/cabal-install/Distribution/Client/Setup.hs#L1617 for an example.

angerman · 2018-01-18T13:48:45Z

Note to self: hidden flag is missing to for this to close.

This change adds the ability to pass `--prefix=\${pkgroot}`. It is on purpose undocumented, as it should be only used with absolute care.

angerman · 2018-01-19T06:34:00Z

@23Skidoo is this good to go with the hidden flags? (assuming CI doesn't throw up).

23Skidoo · 2018-01-19T15:28:17Z

@angerman Yep, this is good to go.

angerman force-pushed the feature/pkg-root branch from 1819704 to e3dd744 Compare November 20, 2017 09:28

23Skidoo reviewed Nov 24, 2017

View reviewed changes

ezyang closed this Dec 30, 2017

ezyang reopened this Dec 30, 2017

angerman self-assigned this Jan 19, 2018

angerman added 6 commits January 19, 2018 14:00

Allow ${pkgroot} prefix.

08f7b13

This change adds the ability to pass `--prefix=\${pkgroot}`. It is on purpose undocumented, as it should be only used with absolute care.

Adds --target-packge-db

5303684

Default flags.

c7edd1c

Allow multiple destdir

1646204

Adds documentation to CopyToDb

1283d83

Hide --target-package-db flag

e98bbd3

angerman force-pushed the feature/pkg-root branch from 9e40864 to e98bbd3 Compare January 19, 2018 06:33

angerman merged commit 429fbc7 into haskell:master Jan 21, 2018

This was referenced Feb 5, 2018

Fix Hidden Args. #5111

Merged

Cabal release for GHC 8.4 #5075

Closed

23Skidoo added this to the 2.2 milestone Feb 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow ${pkgroot} prefix. #4892

Allow ${pkgroot} prefix. #4892

angerman commented Nov 15, 2017

angerman commented Nov 15, 2017

23Skidoo commented Nov 15, 2017

angerman commented Nov 15, 2017

angerman commented Nov 20, 2017

angerman commented Nov 23, 2017

23Skidoo Nov 24, 2017

angerman Nov 25, 2017

angerman Nov 26, 2017

23Skidoo Nov 24, 2017

angerman Nov 25, 2017

23Skidoo Nov 24, 2017

angerman Nov 25, 2017

23Skidoo commented Nov 27, 2017

angerman commented Jan 18, 2018

angerman commented Jan 19, 2018

23Skidoo commented Jan 19, 2018

Allow ${pkgroot} prefix. #4892

Allow ${pkgroot} prefix. #4892

Conversation

angerman commented Nov 15, 2017

angerman commented Nov 15, 2017

23Skidoo commented Nov 15, 2017

angerman commented Nov 15, 2017

angerman commented Nov 20, 2017

angerman commented Nov 23, 2017

23Skidoo Nov 24, 2017

Choose a reason for hiding this comment

angerman Nov 25, 2017

Choose a reason for hiding this comment

angerman Nov 26, 2017

Choose a reason for hiding this comment

23Skidoo Nov 24, 2017

Choose a reason for hiding this comment

angerman Nov 25, 2017

Choose a reason for hiding this comment

23Skidoo Nov 24, 2017

Choose a reason for hiding this comment

angerman Nov 25, 2017

Choose a reason for hiding this comment

23Skidoo commented Nov 27, 2017

angerman commented Jan 18, 2018

angerman commented Jan 19, 2018

23Skidoo commented Jan 19, 2018