Flipping demand
#862
Merged
Flipping demand
#862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardly a better refactor currently. But after the proper the further work on
`force` going to give beautiful code:
```haskell
f =
pure $
case
free
force
id
of
NVStr' s -> pure s
_ -> mempty
```
…tion Argument order change has functional argument - so it is not possible to elegantly switch into new code, and requires to go though transition. So doing the work while doing needed refactoring at the same time. This style of code currenly may seem more noizy, but really it is more straight-forward, it mentions only operations & transformatios, types can be looked in the HLS. With the future work #850 this style of the code would radically start to simplify itself, so please bear with me.
|
Currently surprised the benchmark saves are still small. Sadly, the benchmarks so far not show huge improvement. But need to inspect the profiling more. I wait on one at the end of #850. But more and more thinking that 1-threadness with no system of lock management, flipped style in which the project was created produces unoptimized code and lazy boxed types are the main points. Maybe they are the main nails performance hangs on in the thunk processing. The more we streamline the code - the more magnitude of the gains would start to snowball. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A milestone stage towards #850
Remember that
forcewould lose the functional argument.demandwould be something along the lines offree -> f =<< force thunk.By the result of the
demand- it would be seen, is in viable to keep it, or simply replace with thatfree -> f =<< force thunkor movefreelogic intoforceand useforcewith=<<.So instead of the
demandit would be between function and its argument would beforce v.In other words, unflipping required to unfold the code.
But the further following folded elegantness worth it.
Also all those
\casereally are helper functions that explain themself.Or,
algif you want.