Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please, form code into canonical thunk locking mechanism #861

Closed
Anton-Latukha opened this issue Feb 25, 2021 · 3 comments
Closed

Please, form code into canonical thunk locking mechanism #861

Anton-Latukha opened this issue Feb 25, 2021 · 3 comments

Comments

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Feb 25, 2021

Currently, the code does the thunk locking/unlocking customly. And customly reacts to the locked thread.

All that should be unified. Unification is simple.

MonadThunk needs thunk lock management methods.

@Anton-Latukha
Copy link
Collaborator Author

Maybe the handling of the thunks should be hidden. Aka HNix hierarchy allows to abstract MonadThunk instances from the thunk. So just provide the mechanism to the backend as internal top-level functions.

@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Mar 5, 2021

While the handler pattern that often goes also may be overengineering YAGNI, especially at the current moment.
It probably just needs to be with... pattern.

@Anton-Latukha Anton-Latukha changed the title Please, implement canonical thunk locking mechanism Please, form code into canonical thunk locking mechanism May 31, 2021
@Anton-Latukha
Copy link
Collaborator Author

Essentially was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant