Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Terraform configuration with rotate root API permissions #86

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

austingebauer
Copy link
Member

@austingebauer austingebauer commented Feb 1, 2023

Overview

This PR adds on #65 to give the provisioned credentials the API permissions and app role assignments needed for the rotate root feature.

Contributor Checklist

  • Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
    • Vault docs will be added to note minimal permissions needed.
  • Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
    • N/A for acceptance tests. I manually tested this with in-progress rotate root code from @vinay-gopalan.
  • Backwards compatible

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and LGTM! Thanks for adding this, super helpful 🙏🏼

@austingebauer austingebauer merged commit 843ba4a into main Feb 1, 2023
@austingebauer austingebauer deleted the tf-bootstrap-credentials branch February 1, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants