Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades dependencies, adds environment bootstrap #65

Merged
merged 18 commits into from
Nov 4, 2022

Conversation

austingebauer
Copy link
Member

Overview

This PR upgrades dependencies, tooling, and adds development environment automation. Changes in this PR align this repo with tooling in the Vault plugin scaffold.

Local environment bootstrap usage:

make setup-env
source ./bootstrap/terraform/local_environment_setup.sh
make configure
make teardown-env

Test Results:

$ TESTARGS='-count=1' make test
==> Checking that code complies with gofumpt requirements...
CGO_ENABLED=0 go test ./... -count=1 -timeout=20m
ok      github.com/hashicorp/vault-plugin-auth-azure    0.240s
?       github.com/hashicorp/vault-plugin-auth-azure/cmd/vault-plugin-auth-azure        [no test files]

Note that there aren't acceptance tests that actually use Azure resources in this plugin, so that's omitted from this description.

Contributor Checklist

  • Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
  • Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
  • Backwards compatible

@austingebauer
Copy link
Member Author

I still need to update the readme. Will do that tomorrow.

README.md Outdated Show resolved Hide resolved
@fairclothjm
Copy link
Contributor

After fixing my ssh key env this terraform setup and tests all worked great!

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@maxcoulombe maxcoulombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on helpdesk to get access to an Azure account to test the full setup but it looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
TEST?=$$(go list ./...)
EXTERNAL_TOOLS=
BUILD_TAGS?=${TOOL}
GOFMT_FILES?=$$(find . -name '*.go' | grep -v vendor)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be curious to know which makefile vars & targets are deprecated. I hesitated to remove stuff like quickdev, testcompile & others because I wasn't sure if it was part of some CI. But if we know for some it's not part of anyone's wofkflow I'd add the Makefile clean-up in the ACs of the engineering improvement initiative.

README.md Outdated Show resolved Hide resolved
bootstrap/terraform/vm.tf Outdated Show resolved Hide resolved
bootstrap/terraform/vm.tf Show resolved Hide resolved
bootstrap/terraform/vm.tf Outdated Show resolved Hide resolved
tools/go.mod Outdated Show resolved Hide resolved
@maxcoulombe
Copy link

LGTM, important comments are addressed and as for:

  • TF resource naming
  • leaving the required_provider block
  • provisioning resources for both identify types at all time
    These are more questions/observations than suggestions. Happy to chat if you have questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants