Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nodepool concurrent ops scale better #20738

Conversation

modular-magician
Copy link
Collaborator

The purpose of this change is to stagger operation creations, but still keeps operations concurrent, so that operations are not bottlenecked on creation and fail.
To achieve the above,

  • a cluster-scope lock is held for operation creation
  • cluster-scope lock is released after creation is done
  • cluster-scope read lock is held while waiting for operation to complete (as before)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: make nodepool concurrent operations scale better

Derived from GoogleCloudPlatform/magic-modules#12488

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

[upstream:1dbed42bb9ea904991e432c09a28fffca929452e]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner December 18, 2024 17:08
@modular-magician modular-magician merged commit b3cd6a6 into hashicorp:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant