Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add exp claim to google_service_account_jwt #12488

Closed
rwblokzijl opened this issue Sep 7, 2022 · 2 comments
Closed

Automatically add exp claim to google_service_account_jwt #12488

rwblokzijl opened this issue Sep 7, 2022 · 2 comments
Assignees
Milestone

Comments

@rwblokzijl
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

In #6686 the google_service_account_jwt resource was added. However, as opposed to the associated gcloud command (gcloud beta iam service-accounts sign-jwt), the exp field is not automatically added to the payload. This is made extra annoying by the fact that terraform has no proper way of generating the current time as a unix time stamp.

My request:

  • Add an expires_in field to the resource that takes the time that the JWT should be valid for. (adds exp to the payload in the background)
  • Optionally, add expiry in 1 hour by default (like gloud does)

Affected Resource

  • google_service_account_jwt

References

#6686

@c2thorn
Copy link
Collaborator

c2thorn commented Sep 12, 2022

closed with GoogleCloudPlatform/magic-modules#6429

@c2thorn c2thorn closed this as completed Sep 12, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants