Use regular string sorting for custom access context manager ingress and egress flatteners #20294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and egress flatteners (hashicorp#12288) Co-authored-by: Charlesleonius <charlesleon@google.com> [upstream:0616a35f4dddbca1857fbc0c1330bc5ea93cc7e5] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
deleted the
downstream-pr-0616a35f4dddbca1857fbc0c1330bc5ea93cc7e5
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SortStringsByConfigOrder function fails when there are duplicate items in the array which is a problem since duplicates are allowed by the API. Instead, we are using a regular string sort on both arrays and comparing them, if they are equal, we return the config value so that Terraform sees the state as being unchanged. If the arrays aren't equal, return the API response.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#12288