Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regular string sorting for custom access context manager ingress and egress flatteners #12288

Conversation

Charlesleonius
Copy link
Member

@Charlesleonius Charlesleonius commented Nov 9, 2024

The SortStringsByConfigOrder function fails when there are duplicate items in the array which is a problem since duplicates are allowed by the API. Instead, we are using a regular string sort on both arrays and comparing them, if they are equal, we return the config value so that Terraform sees the state as being unchanged. If the arrays aren't equal, return the API response.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

accesscontextmanager: Fix permadiff in perimeter ingress / egress rules when there are duplicate resources in the rules

Copy link

github-actions bot commented Nov 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 32 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 4 files changed, 32 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • accesscontextmanager

🟢 All tests passed!

View the build log

@rileykarson rileykarson merged commit 0616a35 into GoogleCloudPlatform:main Nov 11, 2024
13 of 14 checks passed
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
…and egress flatteners (GoogleCloudPlatform#12288)

Co-authored-by: Charlesleonius <charlesleon@google.com>
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Nov 18, 2024
…and egress flatteners (GoogleCloudPlatform#12288)

Co-authored-by: Charlesleonius <charlesleon@google.com>
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
…and egress flatteners (GoogleCloudPlatform#12288)

Co-authored-by: Charlesleonius <charlesleon@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants