logging_project_bucket_config: support "no preference" for enable_analytics setting. #19126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lytics setting. (hashicorp#11430) [upstream:90589fba9e124d25ece290f144942815c267daf5] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-90589fba9e124d25ece290f144942815c267daf5
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19099
Before this change, omitting the
enable_analyticsoption was interpreted as a desire to specifically disable analytics during logging bucket creation. This updates the behavior to omit the field in the creation if the user didn't specify it, better reflecting user intent.For existing and new templates, this has no practical effect -- omitting the field will still create a bucket without analytics, but this provides more context in the creation request to the Logging API.
Also fixed typos in an existing log statement.
Derived from GoogleCloudPlatform/magic-modules#11430