Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging_project_bucket_config: support "no preference" for enable_analytics setting. #11430

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

yackmaster
Copy link
Contributor

Addresses hashicorp/terraform-provider-google#19099

Before this change, omitting the enable_analytics option was interpreted as a desire to specifically disable analytics during logging bucket creation. This updates the behavior to omit the field in the creation if the user didn't specify it, better reflecting user intent.

For existing and new templates, this has no practical effect -- omitting the field will still create a bucket without analytics, but this provides more context in the creation request to the Logging API.

Also fixed typos in an existing log statement.

logging: changed enable_analytics parsing to "no preference" in analytics if omitted, instead of explicitly disabling analytics.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from BBBmau August 12, 2024 21:10
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/logging and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 12, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 6 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 68
Skipped tests: 2
Affected tests: 6

Click here to see the affected service packages
  • logging

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccLoggingBucketConfigProject_analyticsEnabled
  • TestAccLoggingBucketConfigProject_basic
  • TestAccLoggingBucketConfigProject_cmekSettings
  • TestAccLoggingBucketConfigProject_indexConfigs
  • TestAccLoggingBucketConfig_CreateBuckets_withCustomId
  • TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLoggingBucketConfigProject_analyticsEnabled[Debug log]
TestAccLoggingBucketConfigProject_basic[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccLoggingBucketConfigProject_indexConfigs[Debug log]
TestAccLoggingBucketConfig_CreateBuckets_withCustomId[Debug log]
TestAccLoggingProjectSink_updatePreservesCustomWriter[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants