-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging_project_bucket_config: support "no preference" for enable_analytics setting. #11430
Conversation
… explicitly specified by user.
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 76 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Addresses hashicorp/terraform-provider-google#19099
Before this change, omitting the
enable_analytics
option was interpreted as a desire to specifically disable analytics during logging bucket creation. This updates the behavior to omit the field in the creation if the user didn't specify it, better reflecting user intent.For existing and new templates, this has no practical effect -- omitting the field will still create a bucket without analytics, but this provides more context in the creation request to the Logging API.
Also fixed typos in an existing log statement.