Add missing depends_on arguments in various acceptance tests #16890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rp#9654) * Add missing IAM resources dependencies in `TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey` * Add missing dependencies * Add missing IAM resources dependencies in `google_sql_database_instance` tests * Add missing IAM resources dependencies in `google_vertex_ai_endpoint` tests * Update mmv1/third_party/terraform/services/alloydb/resource_alloydb_backup_test.go * Update mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go * Update mmv1/third_party/terraform/services/bigquery/resource_bigquery_dataset_test.go [upstream:aeb1f5faa1cb210fefe8ad2f7a3b492fd6b1dd40] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I recently fixed a few nightly test failures due to IAM resources not being provisioned before dependent resources I've found a bunch of other tests that can be updated in the same way but aren't necessarily related to a failing test.
This PR is just enforcing good practices in the Terraform config used in tests.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9654