Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing depends_on arguments in various acceptance tests #9654

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Add missing depends_on arguments in various acceptance tests #9654

merged 8 commits into from
Jan 2, 2024

Conversation

SarahFrench
Copy link
Collaborator

@SarahFrench SarahFrench commented Dec 15, 2023 •
edited
Loading

After I recently fixed a few nightly test failures due to IAM resources not being provisioned before dependent resources I've found a bunch of other tests that can be updated in the same way but aren't necessarily related to a failing test.

This PR is just enforcing good practices in the Terraform config used in tests.

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 42 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 42 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3296
Passed tests 2956
Skipped tests: 337
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbBackup_usingCMEK|TestAccBigQueryDataset_cmek|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_usingCMEK[Error message] [Debug log]
TestAccBigQueryDataset_cmek[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 42 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 42 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3296
Passed tests 2958
Skipped tests: 337
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigQueryDataset_cmek

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataset_cmek[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@SarahFrench SarahFrench marked this pull request as draft December 18, 2023 19:54
@SarahFrench SarahFrench marked this pull request as ready for review January 2, 2024 11:27
@SarahFrench
Copy link
Collaborator Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 26 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 6 files changed, 26 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 292
Passed tests 267
Skipped tests: 25
Affected tests: 0

Click here to see the affected service packages
  • alloydb
  • sql
  • vertexai
  • bigquery

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

zli82016
zli82016 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching the tests.

@SarahFrench
Copy link
Collaborator Author

Just addressed a merge conflict - I'll let the automation finish before possibly merging

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 26 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 6 files changed, 26 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 292
Passed tests 267
Skipped tests: 25
Affected tests: 0

Click here to see the affected service packages
  • alloydb
  • sql
  • vertexai
  • bigquery

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@SarahFrench SarahFrench merged commit aeb1f5f into main Jan 2, 2024
11 checks passed
This was referenced Jan 2, 2024
Merged
Merged
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
@SarahFrench @kapreus
Add missing depends_on arguments in various acceptance tests (GoogleC…
2543ec5 
…loudPlatform#9654)

* Add missing IAM resources dependencies in `TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey`

* Add missing dependencies

* Add missing IAM resources dependencies in `google_sql_database_instance` tests

* Add missing IAM resources dependencies in `google_vertex_ai_endpoint` tests

* Update mmv1/third_party/terraform/services/alloydb/resource_alloydb_backup_test.go

* Update mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go

* Update mmv1/third_party/terraform/services/bigquery/resource_bigquery_dataset_test.go
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
@SarahFrench
Add missing depends_on arguments in various acceptance tests (GoogleC…
c9922c6 
…loudPlatform#9654)

* Add missing IAM resources dependencies in `TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey`

* Add missing dependencies

* Add missing IAM resources dependencies in `google_sql_database_instance` tests

* Add missing IAM resources dependencies in `google_vertex_ai_endpoint` tests

* Update mmv1/third_party/terraform/services/alloydb/resource_alloydb_backup_test.go

* Update mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go

* Update mmv1/third_party/terraform/services/bigquery/resource_bigquery_dataset_test.go
@SarahFrench SarahFrench deleted the add-missing-depends_on-acctests branch February 6, 2024 11:01
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@SarahFrench @balanaguharsha
Add missing depends_on arguments in various acceptance tests (GoogleC…
54b8996 
…loudPlatform#9654)

* Add missing IAM resources dependencies in `TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey`

* Add missing dependencies

* Add missing IAM resources dependencies in `google_sql_database_instance` tests

* Add missing IAM resources dependencies in `google_vertex_ai_endpoint` tests

* Update mmv1/third_party/terraform/services/alloydb/resource_alloydb_backup_test.go

* Update mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go

* Update mmv1/third_party/terraform/services/bigquery/resource_bigquery_dataset_test.go
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@SarahFrench @pengq-google
Add missing depends_on arguments in various acceptance tests (GoogleC…
ba0ac9d 
…loudPlatform#9654)

* Add missing IAM resources dependencies in `TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey`

* Add missing dependencies

* Add missing IAM resources dependencies in `google_sql_database_instance` tests

* Add missing IAM resources dependencies in `google_vertex_ai_endpoint` tests

* Update mmv1/third_party/terraform/services/alloydb/resource_alloydb_backup_test.go

* Update mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go

* Update mmv1/third_party/terraform/services/bigquery/resource_bigquery_dataset_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zli82016 zli82016 zli82016 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SarahFrench @modular-magician @zli82016