Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new google_compute_regions #1603

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Add new google_compute_regions #1603

merged 3 commits into from
Jun 7, 2018

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Jun 6, 2018

Fixes #1602

@sebglon
Copy link
Contributor Author

sebglon commented Jun 6, 2018

make testacc TEST=./google TESTARGS='-run=TestAccComputeRegions_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeRegions_basic -timeout 120m
=== RUN TestAccComputeRegions_basic
=== PAUSE TestAccComputeRegions_basic
=== CONT TestAccComputeRegions_basic
--- PASS: TestAccComputeRegions_basic (1.73s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 1.746s

# google\_compute\_regions

Provides access to available Google Compute regions for a given project.
See more about [regions and regions](https://cloud.google.com/compute/docs/regions-regions/regions-regions) in the upstream docs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is broken. And regions and regions is a bit redundant ;)

I believe you wanted to link to regions and zones?
https://cloud.google.com/compute/docs/regions-zones/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sorry.
changed

@rosbo rosbo merged commit d766990 into hashicorp:master Jun 7, 2018
olvesh pushed a commit to olvesh/terraform-provider-google that referenced this pull request Jun 8, 2018
…-google

* 'master' of https://github.com/olvesh/terraform-provider-google: (24 commits)
  Cleanup after v1.14.0 release
  v1.14.0
  Update CHANGELOG.md
  Add new google_compute_regions (hashicorp#1603)
  Update CHANGELOG.md
  Fix forwarding rule data source test (hashicorp#1606)
  Update CHANGELOG.md
  Fix redis authorized network and tests. The Redis API currently only accepts partial links. The tests weren't failing because they weren't actually using the network (oops). There were a few other test issues that I fixed while I was there. Fixes hashicorp#1571. (hashicorp#1599)
  update auth docs (hashicorp#1587)
  Fix network_tier tests.
  Add documentation for network tier (hashicorp#1593)
  Warn about ip_version with ip_address in global forwarding rule (hashicorp#616)
  Update CHANGELOG.md
  add support for network tiers (hashicorp#1530)
  Update CHANGELOG.md
  Allow using in repo configuration for cloudbuild trigger (hashicorp#1557)
  Update CHANGELOG.md
  add update support for redis (hashicorp#1590)
  Update CHANGELOG.md
  Added GCP Netblock Data Source (hashicorp#1416) (hashicorp#1580)
  ...
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
* Add new google_compute_regions

* Add docs

* correct doc
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants