Added GCP Netblock Data Source #1580
Conversation
|
PR to #1416 |
|
We also need to add docs. |
|
Hi Tenorio, The docs for data source live under website/docs/d, you can add a new file there for this data source. Then, you can add an entry in the side-menu in the google.erb file. |
|
Hi, added the docs. |
| Elem: &schema.Schema{Type: schema.TypeString}, | ||
| Computed: true, | ||
| }, | ||
| "cidr_blocks_ip4": { |
There was a problem hiding this comment.
For the sake of consistency with our other resources like cluster and route, let's call this field: cidr_blocks_ipv4. Same for the ipv6 block below.
|
Merging! Thanks a lot for your contribution. |
rosbo
changed the title
…-google * 'master' of https://github.com/olvesh/terraform-provider-google: (24 commits) Cleanup after v1.14.0 release v1.14.0 Update CHANGELOG.md Add new google_compute_regions (hashicorp#1603) Update CHANGELOG.md Fix forwarding rule data source test (hashicorp#1606) Update CHANGELOG.md Fix redis authorized network and tests. The Redis API currently only accepts partial links. The tests weren't failing because they weren't actually using the network (oops). There were a few other test issues that I fixed while I was there. Fixes hashicorp#1571. (hashicorp#1599) update auth docs (hashicorp#1587) Fix network_tier tests. Add documentation for network tier (hashicorp#1593) Warn about ip_version with ip_address in global forwarding rule (hashicorp#616) Update CHANGELOG.md add support for network tiers (hashicorp#1530) Update CHANGELOG.md Allow using in repo configuration for cloudbuild trigger (hashicorp#1557) Update CHANGELOG.md add update support for redis (hashicorp#1590) Update CHANGELOG.md Added GCP Netblock Data Source (hashicorp#1416) (hashicorp#1580) ...
* Added GCP Netblock Data Source (hashicorp#1416) * Added docs for google_netblock_ip_ranges (hashicorp#1416) * Code review changes (hashicorp#1416)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #1416