-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_monitor_action_group - add support for the use_common_alert_schema
webhook property
#4483
Conversation
Updated Azure SDK API for insights to 2019-06-01
Build seems to fail, because travis does not know / import the updated dependency https://github.com/Azure/azure-sdk-for-go/tree/master/services/preview/monitor/mgmt/2019-06-01/insights |
Hey @phires, dependencies are updated manually so you'll have to do this yourself. The below should do the trick
|
Fix is commited, anythint I can do to resolve the conflicts? |
You can merge the latest master to your branch to resolve these conflicts: https://stackoverflow.com/questions/26241428/this-pull-request-contains-merge-conflicts-that-must-be-resolved I am looking forward to seeing this feature in v1.36.0. |
Finally :) Thank you all, I'm learning something new every day! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phires, It seems like there are an excessive number of changes in this PR? many vendored in packages are being removed.. i'm not sure that is accurate? i tried to fix things locally but i can't push to your branch
@katbyte Well, I guess I have to read up on all those "mod" stuff... |
@phires Can you also add me as a collaborator to your repo? I will try to sort it out with the missing files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @phires!
I've merged master & that fixed up the diff, LGTM now 👍
use_common_alert_schema
webhook property
- Adds arm_role_receiver - Adds use_common_alert_schema to all supported receivers - Changes require insights import change from hashicorp#4483
This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.36.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Updated Azure SDK API for insights to 2019-06-01 to be able to use the option 'UseCommonAlertSchema'
(fixs #3363)