Support all action group receivers

[mcdafydd]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

I am interested in adding support for the other seven receiver types listed in the SDK in addition to the currently supported SMS, email, and webhook:

https://github.com/Azure/azure-sdk-for-go/blob/7a9d2769e4a581b0b1bc609c71b59af043e05c98/services/preview/monitor/mgmt/2019-03-01/insights/models.go#L682-L707

New or Affected Resource(s)

• azurerm_monitor_action_group

Potential Terraform Configuration

resource "azurerm_monitor_action_group" "test" {
  name                = "CriticalAlertsAction"
  resource_group_name = "${azurerm_resource_group.test.name}"
  short_name          = "p0action"

  itsm_receiver {
    name          = "createorupdateticket"
    workspace_id = "6eee3a18-aac3-40e4-b98e-1f309f329816"
    connection_id = "53de6956-42b4-41ba-be3c-b154cdf17b13"
    ticket_configuration = "{}"
    region = "southcentralus"
  }
  azure_app_push_receiver {
    name          = "pushtoadmin"
    email_address = "admin@contoso.com"
  }
  arm_role_receiver {
    "name": "Monitoring Reader",
    "roleId": "43d0d8ad-25c7-4714-9337-8ba259a9fe05",
    "useCommonAlertSchema": false
  }
  automation_runbook_receiver {}
  voice_receiver {}
  logic_app_receiver {}
  azure_function_receiver {} 
}

References

[mcdafydd]

I'm almost ready with a PR for this one.

[mcdafydd]

I just finished an end-to-end test using an azure_app_push_receiver so will submit the PR today.

Question - the current import path for action groups uses

"github.com/Azure/azure-sdk-for-go/services/preview/monitor/mgmt/2018-03-01/insights"

This version of the API supports 9 different action group receiver types. The Azure Portal now supports 11, including an arm role receiver and secured webhook. What's the usual guidance for updating import paths to use new versions of the azure-sdk-for-go APIs? If I wanted to update this version and include the two additional receiver types, is this something I could include in this PR?

Thanks for any help!

[tombuildsstuff]

hey @mcdafydd

Thanks for opening this issue (and the PR 😄)

What's the usual guidance for updating import paths to use new versions of the azure-sdk-for-go APIs?

In general we'd ask that SDK upgrades and new functionality are decoupled as two separate/smaller PR's if possible - this is mostly to avoid conflicts in the go.mod which gets modified quite frequently where new functionality is added/the Go SDK gets upgraded.

As such, in this case since you've opened #4260 would you mind holding off sending the PR to upgrade the SDK/API version until after #4260 has been merged? On that note I'll take a look through that shortly :)

Thanks!

[mcdafydd]

As such, in this case since you've opened #4260 would you mind holding off sending the PR to upgrade the SDK/API version until after #4260 has been merged?

Hi again,

#4483 took care of the SDK import that I needed to include the bits I added in #4638. If it makes sense to you @tombuildsstuff, it's totally fine with me to merge #4638 instead of #4260. Whatever works best.

Thanks!

[tombuildsstuff]

Fixed via #4638 - thanks again @mcdafydd :)

[ghost]

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!