Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_stream_analytics_job Removing requirement of optional properties #4190

Merged
merged 5 commits into from
Sep 13, 2019
Merged

azurerm_stream_analytics_job Removing requirement of optional properties #4190

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e13836
Removing requirement of optional properties
nexxai Aug 29, 2019
dd833fc
make fmt
nexxai Aug 29, 2019
0d28e77
Refactored 'basic' test into 'basic' and 'complete'; updated docs
nexxai Aug 30, 2019
c70160a
Reverting updates; continuing next week
nexxai Aug 30, 2019
e37e116
Fixed default optional settings; tests are passing now
nexxai Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions azurerm/resource_arm_stream_analytics_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func resourceArmStreamAnalyticsJob() *schema.Resource {

"compatibility_level": {
Type: schema.TypeString,
Required: true,
Optional: true,
nexxai marked this conversation as resolved.
Show resolved Hide resolved
ValidateFunc: validation.StringInSlice([]string{
// values found in the other API the portal uses
string(streamanalytics.OneFullStopZero),
Expand All @@ -55,27 +55,27 @@ func resourceArmStreamAnalyticsJob() *schema.Resource {

"data_locale": {
Type: schema.TypeString,
Required: true,
Optional: true,
ValidateFunc: validate.NoEmptyStrings,
},

"events_late_arrival_max_delay_in_seconds": {
Type: schema.TypeInt,
Required: true,
Optional: true,
// portal allows for up to 20d 23h 59m 59s
ValidateFunc: validation.IntBetween(-1, 1814399),
},

"events_out_of_order_max_delay_in_seconds": {
Type: schema.TypeInt,
Required: true,
Optional: true,
// portal allows for up to 9m 59s
ValidateFunc: validation.IntBetween(0, 599),
},

"events_out_of_order_policy": {
Type: schema.TypeString,
Required: true,
Optional: true,
ValidateFunc: validation.StringInSlice([]string{
string(streamanalytics.Adjust),
string(streamanalytics.Drop),
Expand All @@ -84,7 +84,7 @@ func resourceArmStreamAnalyticsJob() *schema.Resource {

"output_error_policy": {
Type: schema.TypeString,
Required: true,
Optional: true,
ValidateFunc: validation.StringInSlice([]string{
string(streamanalytics.OutputErrorPolicyDrop),
string(streamanalytics.OutputErrorPolicyStop),
Expand All @@ -93,13 +93,13 @@ func resourceArmStreamAnalyticsJob() *schema.Resource {

"streaming_units": {
Type: schema.TypeInt,
Required: true,
Optional: true,
ValidateFunc: validate.StreamAnalyticsJobStreamingUnits,
},

"transformation_query": {
Type: schema.TypeString,
Required: true,
Optional: true,
ValidateFunc: validate.NoEmptyStrings,
},

Expand Down