azurerm_stream_analytics_job Removing requirement of optional properties

[nexxai]

Fixes #3342

[tombuildsstuff]

LGTM - thanks for this @nexxai 👍

[tombuildsstuff]

on reflection - could we add a test covering this?

[katbyte]

Hi @nexxai,

Just running the tests here and it looks like a couple changes will be required:

UPDATE: azurerm_stream_analytics_job.test
          compatibility_level:                      "1.0" => ""
          data_locale:                              "en-US" => ""
          events_late_arrival_max_delay_in_seconds: "0" => "0"
          events_out_of_order_max_delay_in_seconds: "0" => "0"
          events_out_of_order_policy:               "" => ""
          id:                                       "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestRG-190830213327899924/providers/Microsoft.StreamAnalytics/streamingjobs/acctestjob-190830213327899924" => "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestRG-190830213327899924/providers/Microsoft.StreamAnalytics/streamingjobs/acctestjob-190830213327899924"
          job_id:                                   "5dbbda43-2eaa-406d-857d-d378043f1cf8" => "5dbbda43-2eaa-406d-857d-d378043f1cf8"
          location:                                 "westeurope" => "westeurope"
          name:                                     "acctestjob-190830213327899924" => "acctestjob-190830213327899924"
          output_error_policy:                      "Stop" => ""
          resource_group_name:                      "acctestRG-190830213327899924" => "acctestRG-190830213327899924"
          streaming_units:                          "3" => "3"
          tags.environment:                         "Test" => "Test"
          transformation_query:                     "    SELECT *\n    INTO [YourOutputAlias]\n    FROM [YourInputAlias]\n" => "    SEL

Since these properties are given a default by the API we'll need to mark them as computed so terraform doesn't try and set them to empty values.

IIRC this API might not be happy when you set those objects in the object. So we'll have to now conditionally set them if they are not empty. IE only set DataLocal if its not ""

[nexxai]

I had just made those changes temporarily while @mbfrahry and I were trying to troubleshoot the problem. He and I have a pair programming session set up for Wed. afternoon to figure out the issue.

[nexxai]

After session with @mbfrahry all tests are passing. Documentation is updated.

[tombuildsstuff]

hey @nexxai

Thanks for pushing those changes - taking a look through this LGTM 👍

Thanks!

dismissing since changes have been pushed

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!