Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_app_environment - add support for Consumption workload profile #25285

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

jackofallops
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

New Feature Submissions

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why below)

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Documentation Changes

  • Documentation is written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.

Description

This PR adds support for the Consumption workload profile SKU. Environments created without any profiles cannot have them added later. The Consumption profile is always present, so can be omitted from configurations that already use at least one other Workload Profile. This option is included to facilitate the ability to create an azurerm_container_app_environment that can have Workload Profiles added and removed at a later time.

Note: This resource will be conditionally ForceNew if all profiles are removed from the configuration, or if a profile is introduced to an existing resource which was created without any workload_profile blocks.

Testing Logs/Evidence

Related Issue(s)

Fixes #24198

Supersedes #24277

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_container_app_environment - add support for Consumption workload profile

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor points but otherwise 👍

@jackofallops jackofallops merged commit 18d93f1 into main Mar 19, 2024
32 checks passed
@jackofallops jackofallops deleted the f/container-app-env-workload-consumption branch March 19, 2024 14:26
@github-actions github-actions bot added this to the v3.97.0 milestone Mar 19, 2024
jackofallops added a commit that referenced this pull request Mar 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants