Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to handle Consumption in workload profile #24302

Closed
wants to merge 1 commit into from

Conversation

DenisBalan
Copy link

As part of #23478 workload profiles were introduced.

There is an important distinction between
Consumption as a type of workload profile and
Consumption completly apart from workload profile.

This PR is to add Consumption as workload profile type.

ref: https://learn.microsoft.com/en-us/azure/container-apps/workload-profiles-overview#profile-types
related also: #21747

@MilanMercantile
Copy link

Can anyone look into this ASAP?

@krisgeus
Copy link

krisgeus commented Jan 18, 2024

@DenisBalan Is it possible to also add the GPU profiles (preview) to this? Validation rule prevents selection of NC24-A100, NC48-A100 and NC96-A100

@damienaicheh
Copy link

damienaicheh commented Jan 18, 2024

Is this not the same as this PR? #24277

Copy link

github-actions bot commented Mar 4, 2024

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

@github-actions github-actions bot added the stale label Mar 4, 2024
@meizenga
Copy link

meizenga commented Mar 4, 2024

Please merge this PR. Thanks

@github-actions github-actions bot removed the stale label Mar 4, 2024
@ltmleo
Copy link

ltmleo commented Mar 5, 2024

Any update?

@ltmleo
Copy link

ltmleo commented Mar 5, 2024

Is this not the same as this PR? #24277

I don`t think this is the same, because you can choose the default workload profile, which is the 'consumption', but it is not the consumptionOnly environment type. This is quite confusing.
image
I can't replicate the Consumption workload profile, as a new profile, so this is a big need for me.

@kewalaka
Copy link

kewalaka commented Mar 5, 2024

The Azure Verified Module (https://aka.ms/AVM) here supports the consumption only environment:

https://registry.terraform.io/modules/Azure/avm-res-app-managedenvironment/azurerm/latest

Example:

module "managedenvironment" {
  source  = "Azure/avm-res-app-managedenvironment/azurerm"
  version = "0.1.0"

  name                                 = "cae-my-example"
  resource_group_name                  = azurerm_resource_group.this.name
  infrastructure_subnet_id             = azurerm_subnet.this.id
  workload_consumption_profile_enabled = true
  zone_redundancy_enabled              = true

  log_analytics_workspace_customer_id        = azurerm_log_analytics_workspace.this.workspace_id
  log_analytics_workspace_primary_shared_key = azurerm_log_analytics_workspace.this.primary_shared_key
}

@tombuildsstuff
Copy link
Contributor

hey @DenisBalan

Thanks for this PR - taking a look through here it appears this PR has been superseded/included as a part of #25285 and as such I hope you don't mind but I'm going to close this PR in favour of that one, which'll ship in this weeks release.

Thanks!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants