Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_lb_nat_pool: backporting azurestack changes #1748

Merged
merged 6 commits into from
Aug 9, 2018
Merged

azurerm_lb_nat_pool: backporting azurestack changes #1748

merged 6 commits into from
Aug 9, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Aug 9, 2018 •
edited
Loading

  • back porting changes from this azurestack PR
  • changing LoadBalancer -> Load Balancer to better match azure documentaiton
  • add new protocol validation and option All

@katbyte katbyte added this to the 1.13.0 milestone Aug 9, 2018
@katbyte katbyte force-pushed the lb-nat-pool-azurestack_updates branch 2 times, most recently from 0022001 to 9a2f801 Compare August 9, 2018 19:01
tombuildsstuff
tombuildsstuff approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte force-pushed the lb-nat-pool-azurestack_updates branch from f3b5ad1 to 0aa1513 Compare August 9, 2018 19:39
@katbyte
Copy link
Collaborator Author

katbyte commented Aug 9, 2018

tests pass:
screen shot 2018-08-09 at 15 43 02

@katbyte
Copy link
Collaborator Author

katbyte commented Aug 9, 2018

more passing tests
screen shot 2018-08-09 at 16 10 30

@katbyte katbyte merged commit 3c6a1ad into master Aug 9, 2018
@katbyte katbyte deleted the lb-nat-pool-azurestack_updates branch August 9, 2018 23:11
katbyte added a commit that referenced this pull request Aug 9, 2018
@katbyte
Update CHANGELOG.md to include #1748
3ee166d
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement service/load-balancers
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@katbyte @tombuildsstuff