mysql_virtual_network_rule waitLRO
#16043
Conversation
| log.Printf("[DEBUG] Waiting for %s to become ready", id) | ||
| stateConf := &pluginsdk.StateChangeConf{ |
There was a problem hiding this comment.
have you confirmed this is no longer required?
There was a problem hiding this comment.
ping @shu-ying789 - have you confirmed that this is no longer required? the LRO itself didn't correctly wait for the ProvisioningState at one point in time.
There was a problem hiding this comment.
Hi @tombuildsstuff , based on the tests, it seems that this is no longer required.
There was a problem hiding this comment.
IMHO can we still keep the stateConf wait logic here, while only add up for the missing wait for future part in each of these PRs, to avoid any surprise?
There was a problem hiding this comment.
Makes sense to me - when we replace the base layer both of these will be done automatically, but for now keeping both is fine 👍
There was a problem hiding this comment.
@tombuildsstuff stateConf I added it again, please check again, thanks!
|
This functionality has been released in v3.2.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
linked to #15641