-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LRO using Azure SDK Track1 forgets to wait #15641
Labels
Comments
This was referenced Mar 4, 2022
Merged
This was referenced Mar 10, 2022
Merged
This was referenced Mar 15, 2022
This was referenced Mar 18, 2022
Closed
This was referenced Mar 25, 2022
@magodo i think many of the checks can be checked off now? |
@katbyte I've marked the merged one to checked and removed (line through) some closed one due to resource being deprecated. While some checks are remain open as the PRs are closed due to other consideratins (e.g. netapp). |
This was referenced Apr 7, 2022
This was referenced Apr 26, 2022
This was referenced May 26, 2022
This was referenced May 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are quite a few places in the codebase that uses the Azure SDK Track1 that forgets to wait for completion of a LRO.
With the help of https://github.com/magodo/terraform-provider-azurerm-lro, we have below list. This issue is only for tracking purpose, each item shown below should be fixed in a dedicated issue.
Not all of the below items are coding mistakes, since some of them are intentially not calling the wait for LRO, which might due to API issues or Swagger mis-configuration, while for this case we still want to ensure a comment right above the LRO to indicate the reason, with a Github issue link to the https://github.com/Azure/azure-rest-api-specs.
apimanagement
automation
network
cosmos
iothub
keyvault
lighthouse
mariadb
mssql
mysql
netapp
notificationhub
privatedns
recoveryservices
resource
internal/services/resource/template_deployment_resource.go:274:5signalr
spingcloud
sql
synapse
web
internal/services/web/function_app_resource.go:175:3The text was updated successfully, but these errors were encountered: