-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_disk_encryption_set
support for enable_auto_key_rotation
#13747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Tbohunek, thanks for this PR. Overall this looks good, there is one suggestion on the schema and the formatting needs to be fixed so the remaining checks can run.
@@ -31,6 +31,11 @@ func dataSourceDiskEncryptionSet() *pluginsdk.Resource { | |||
"location": azure.SchemaLocationForDataSource(), | |||
|
|||
"resource_group_name": azure.SchemaResourceGroupNameForDataSource(), | |||
|
|||
"enable_auto_key_rotation": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename this to follow our convention for boolean properties
"enable_auto_key_rotation": { | |
"auto_key_rotation_enabled": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed the variable, but I cannot format the code from the web editor. Could you please do that for me @stephybun?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tbohunek thanks for renaming that property 🙂. The linting errors need to be addressed next before we can merge this.
Hi @stephybun @myc2h6o I have done what I could hoping to save someone some time, but my ability to code this myself ends here. Please feel free to commit directly what you think is necessary. I will happily observe and keep that in mind for next time. |
Thanks @Tbohunek for making the pull request. I'll update the pr to resolve the comments from stephybun and ms-henglu |
@myc2h6o I just committed what I see as the only difference from your PR. @stephybun could you pls rerun actions? |
Yeah saw your new change @Tbohunek , there is some naming error, e.g. |
Resolve reference error and remove unnecessary test check
Forgot to run terrafmt, here is the fmt update Tbohunek#2 |
Resolve Terrafmt lint error
@Tbohunek I updated the test here: Tbohunek#3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: stephybun <steph@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Azure Disk Encryption Set now supports automatic Key rotation
I worked by #13717 and #8670.
Did I miss anything?