Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_disk_encryption_set support for enable_auto_key_rotation #13747

Merged
merged 12 commits into from
Oct 20, 2021

Conversation

Tbohunek
Copy link
Contributor

Azure Disk Encryption Set now supports automatic Key rotation

I worked by #13717 and #8670.

Did I miss anything?

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tbohunek, thanks for this PR. Overall this looks good, there is one suggestion on the schema and the formatting needs to be fixed so the remaining checks can run.

@@ -31,6 +31,11 @@ func dataSourceDiskEncryptionSet() *pluginsdk.Resource {
"location": azure.SchemaLocationForDataSource(),

"resource_group_name": azure.SchemaResourceGroupNameForDataSource(),

"enable_auto_key_rotation": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename this to follow our convention for boolean properties

Suggested change
"enable_auto_key_rotation": {
"auto_key_rotation_enabled": {

Copy link
Contributor Author

@Tbohunek Tbohunek Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed the variable, but I cannot format the code from the web editor. Could you please do that for me @stephybun?

@katbyte katbyte added this to the v2.82.0 milestone Oct 15, 2021
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tbohunek thanks for renaming that property 🙂. The linting errors need to be addressed next before we can merge this.

@Tbohunek
Copy link
Contributor Author

Hi @stephybun @myc2h6o I have done what I could hoping to save someone some time, but my ability to code this myself ends here. Please feel free to commit directly what you think is necessary. I will happily observe and keep that in mind for next time.

@myc2h6o
Copy link
Contributor

myc2h6o commented Oct 19, 2021

Thanks @Tbohunek for making the pull request. I'll update the pr to resolve the comments from stephybun and ms-henglu

@Tbohunek
Copy link
Contributor Author

@myc2h6o I just committed what I see as the only difference from your PR. @stephybun could you pls rerun actions?
If this is correct then I still don't see how to fix data though.

@myc2h6o
Copy link
Contributor

myc2h6o commented Oct 19, 2021

Yeah saw your new change @Tbohunek , there is some naming error, e.g. rotationToLatestKeyVersionEnabled vs RotationToLatestKeyVersionEnabled I don't have permission to commit to your branch directly thus making a pr to your branch, can you take a look and merge if it looks good?
Tbohunek#1

Tbohunek and others added 2 commits October 19, 2021 09:00
Resolve reference error and remove unnecessary test check
@Tbohunek Tbohunek requested a review from stephybun October 19, 2021 09:02
@myc2h6o
Copy link
Contributor

myc2h6o commented Oct 19, 2021

Forgot to run terrafmt, here is the fmt update Tbohunek#2
The acc tests _update are failing because update of auto_key_rotation_enabled requires a key vault permission but it's not added to the test case yet, I'm looking at updating it

@myc2h6o
Copy link
Contributor

myc2h6o commented Oct 20, 2021

@Tbohunek I updated the test here: Tbohunek#3
Can you take a look? I've put the change detail and the test result there as well

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tbohunek and @myc2h6o. Tests are passing, I have one last suggestion, then this is good to go.

Co-authored-by: stephybun <steph@hashicorp.com>
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@stephybun stephybun merged commit e2a8ec2 into hashicorp:main Oct 20, 2021
stephybun added a commit that referenced this pull request Oct 20, 2021
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants