Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for auto key rotation in azurerm_disk_encryption_set #12531

Closed
AliMBajwa opened this issue Jul 9, 2021 · 5 comments
Closed

Support for auto key rotation in azurerm_disk_encryption_set #12531

AliMBajwa opened this issue Jul 9, 2021 · 5 comments

Comments

@AliMBajwa
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It's possible to create/update a disk encryption set with in the AZ CLI / Portal to automatically rotate keys. There isn't an option to do this via the terraform resource.

Note: I've already tried passing a versionless key ID and i get the following error:

Error: parsing "https://myExampleVault.vault.azure.net/keys/key-myExampleKey": expected a versioned ID but no version in " 
   with azurerm_disk_encryption_set.example_vm,
   on disk-encryption.tf line 5, in resource "azurerm_disk_encryption_set" "example_vm":
    5:   key_vault_key_id    = data.azurerm_key_vault_key.example_vm.versionless_id

New or Affected Resource(s)

  • azurerm_disk_encryption_set
  • data.azurerm_disk_encryption_set

Potential Terraform Configuration

resource "azurerm_disk_encryption_set" "example_vm" {
  name                = "disk-es-${var.virtual_machine_name}"
  resource_group_name = var.resource_group_name
  location            = var.location
  key_vault_key_id    = data.azurerm_key_vault_key.example_vm
  auto_key_rotation = true

  identity {
    type = "SystemAssigned"
  }
}

References

  • #0000
@AliMBajwa
Copy link
Author

Accidentally closed this - reopened immediately after. Sorry!

@johnfriedrich
Copy link

Looks this was added in #13747

@fcatacut
Copy link
Contributor

Looks this was added in #13747

Correct, this was released in v2.82.0. This issue can be closed.

@AliMBajwa
Copy link
Author

Thanks for letting me know on this thread.

For anyone who reads this: I've not confirmed myself it's been added and works (since I don't work on that particular project anymore where it was needed) I'm going off of what the 2 users above have said.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants