Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for auto key rotation in disk encryption set #13766

Closed
wants to merge 1 commit into from
Closed

Add support for auto key rotation in disk encryption set #13766

wants to merge 1 commit into from

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Oct 18, 2021 •
edited
Loading

rotationToLatestKeyVersionEnabled is not present in disk_encryption_set_resource, which makes automatic key rotation not possible.

@stephybun
Copy link
Member

Thanks for this PR @myc2h6o, this appears to be a duplicate of #13747 which also adds the new property to the data source and is already under review. Whilst i'd like to thank you for your contribution I am going to close this in favour of #13747.
Thanks!

@stephybun stephybun closed this Oct 18, 2021
@myc2h6o myc2h6o deleted the disk_enc_auto_rotate branch October 18, 2021 07:19
@myc2h6o myc2h6o mentioned this pull request Oct 18, 2021
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ms-henglu ms-henglu ms-henglu left review comments

Assignees
No one assigned
Labels
documentation duplicate service/disks size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myc2h6o @stephybun @ms-henglu