Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_instance: Remove deprecated top-level network_interface_id attribute #7715

Merged
merged 1 commit into from
Feb 25, 2019
Merged

resource/aws_instance: Remove deprecated top-level network_interface_id attribute #7715

merged 1 commit into from
Feb 25, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 25, 2019 •
edited
Loading

Closes #7690

Output from acceptance testing:

--- PASS: TestAccAWSInstance_addSecondaryInterface (152.51s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (274.60s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (130.37s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (100.05s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (99.71s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (89.49s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (292.12s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (211.33s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (110.19s)
--- PASS: TestAccAWSInstance_basic (240.03s)
--- PASS: TestAccAWSInstance_blockDevices (178.54s)
--- PASS: TestAccAWSInstance_changeInstanceType (332.95s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (99.32s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (104.14s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (359.61s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (216.48s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (367.30s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (69.62s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (233.43s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (307.11s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (308.10s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (302.92s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (92.53s)
--- PASS: TestAccAWSInstance_disableApiTermination (151.40s)
--- PASS: TestAccAWSInstance_disappears (198.32s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (307.42s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (183.41s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (150.51s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (178.25s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (65.03s)
--- PASS: TestAccAWSInstance_importBasic (203.19s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgId (244.09s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgName (115.92s)
--- PASS: TestAccAWSInstance_importInEc2Classic (96.90s)
--- PASS: TestAccAWSInstance_instanceProfileChange (130.56s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (245.32s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (229.85s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (10.22s)
--- PASS: TestAccAWSInstance_keyPairCheck (184.07s)
--- PASS: TestAccAWSInstance_multipleRegions (239.75s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (70.36s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (84.93s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (69.24s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (171.04s)
--- PASS: TestAccAWSInstance_placementGroup (65.25s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (90.76s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (81.20s)
--- PASS: TestAccAWSInstance_privateIP (89.23s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (170.91s)
--- PASS: TestAccAWSInstance_rootInstanceStore (80.55s)
--- PASS: TestAccAWSInstance_sourceDestCheck (145.37s)
--- PASS: TestAccAWSInstance_tags (108.46s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (114.24s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (115.30s)
--- PASS: TestAccAWSInstance_userDataBase64 (234.15s)
--- PASS: TestAccAWSInstance_volumeTags (97.80s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (109.57s)
--- PASS: TestAccAWSInstance_vpc (233.67s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (119.20s)

@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 25, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 25, 2019
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Feb 25, 2019
@bflad bflad mentioned this pull request Feb 25, 2019
Closed
@bflad bflad force-pushed the td-aws_instance-remove-deprecated branch from d7368e6 to 6047825 Compare February 25, 2019 08:11
@bflad
resource/aws_instance: Remove deprecated top-level network_interface_…
9ccbc90 
…id attribute

Reference: #7690

Output from acceptance testing:

```
--- PASS: TestAccAWSInstance_addSecondaryInterface (152.51s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (274.60s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (130.37s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (100.05s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (99.71s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (89.49s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (292.12s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (211.33s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (110.19s)
--- PASS: TestAccAWSInstance_basic (240.03s)
--- PASS: TestAccAWSInstance_blockDevices (178.54s)
--- PASS: TestAccAWSInstance_changeInstanceType (332.95s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (99.32s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (104.14s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (359.61s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (216.48s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (367.30s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (69.62s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (233.43s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (307.11s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (308.10s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (302.92s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (92.53s)
--- PASS: TestAccAWSInstance_disableApiTermination (151.40s)
--- PASS: TestAccAWSInstance_disappears (198.32s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (307.42s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (183.41s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (150.51s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (178.25s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (65.03s)
--- PASS: TestAccAWSInstance_importBasic (203.19s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgId (244.09s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgName (115.92s)
--- PASS: TestAccAWSInstance_importInEc2Classic (96.90s)
--- PASS: TestAccAWSInstance_instanceProfileChange (130.56s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (245.32s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (229.85s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (10.22s)
--- PASS: TestAccAWSInstance_keyPairCheck (184.07s)
--- PASS: TestAccAWSInstance_multipleRegions (239.75s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (70.36s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (84.93s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (69.24s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (171.04s)
--- PASS: TestAccAWSInstance_placementGroup (65.25s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (90.76s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (81.20s)
--- PASS: TestAccAWSInstance_privateIP (89.23s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (170.91s)
--- PASS: TestAccAWSInstance_rootInstanceStore (80.55s)
--- PASS: TestAccAWSInstance_sourceDestCheck (145.37s)
--- PASS: TestAccAWSInstance_tags (108.46s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (114.24s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (115.30s)
--- PASS: TestAccAWSInstance_userDataBase64 (234.15s)
--- PASS: TestAccAWSInstance_volumeTags (97.80s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (109.57s)
--- PASS: TestAccAWSInstance_vpc (233.67s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (119.20s)
```
@bflad bflad force-pushed the td-aws_instance-remove-deprecated branch from 6047825 to 9ccbc90 Compare February 25, 2019 17:46
@bflad
Copy link
Contributor Author

bflad commented Feb 25, 2019

The work for this was actually previously done in #1193 which I merged and now this PR only contains attribute documentation removal. Will self-merge the trivial docs update once TravisCI comes back green.

@bflad bflad merged commit 6ca09ba into master Feb 25, 2019
@bflad bflad deleted the td-aws_instance-remove-deprecated branch February 25, 2019 17:59
bflad added a commit that referenced this pull request Feb 25, 2019
@bflad
Update CHANGELOG for #1193 and #7715
6b50965
tmknom added a commit to tmknom/terraform-aws-session-manager that referenced this pull request Jun 19, 2019
@tmknom
Remove deprecated network_interface_id from outputs
718e4f2 
hashicorp/terraform-provider-aws#7715
tmknom added a commit to tmknom/terraform-aws-session-manager that referenced this pull request Jun 19, 2019
@tmknom
Remove deprecated network_interface_id from outputs
abe359b 
hashicorp/terraform-provider-aws#7715
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

[Version 2 Release] resource/aws_instance: Remove deprecated network_interface_id attribute
1 participant
@bflad